Adding docstrings#134
Open
immasushiroll wants to merge 5 commits into
Open
Conversation
Contributor
|
Thanks @immasushiroll - can you please remove the |
Author
|
@ArtPoon done! changes in data just completely removed, that should be easiest, did you also want to squash those commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! First time contributing, sorry it took so long, I figured these changes aren't that important as they're all comments.
This is a first draft and a low impact PR, so feel free to point out if I my descriptions don't accurately reflect the functional logic, thank you so much for your time and help!
You may see some of the .csv files have changed or have been added. Those were generated from running updater.py, which pulls the latest updates from the APOBEC DRMS database. Basically, I updated the .csv files to a more recent version, I can remove those changes if it's preferred for a cleaner PR.
When I go to test run sierralocal with these changes (specifically the new .csv files) I get the following where it considers it an "unusual file". Would be great if someone could take a look at this just in case, not sure if this behaviour is expected. Test run w/ added docstring changes: